Skip to content

feat: add slackbot.skills.update method - #2019

Merged
zimeg merged 21 commits into
mainfrom
zimeg-feat-slackbot-skills-update
Nov 13, 2026
Merged

zimeg merged 21 commits into
mainfrom
zimeg-feat-slackbot-skills-update

Conversation

@zimeg

@zimeg zimeg commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

This pull request adds the slackbot.skills.update method to the Web API clients.

  • slackbot_skills_update takes a required skill_id and optional category, description, display_name, example_prompt, instructions, and mcp_servers. Sending mcp_servers=[] clears the list.
  • The async and legacy clients are regenerated with scripts/codegen.py, and the method is added to the Web API coverage test.

This is part 3 of 11 in a stack that adds the Slackbot skills methods one at a time, following a skill from creation to deletion. Each pull request builds on the one before it and merges on its own, bottom to top. Related to #2014.

  1. feat: add slackbot.skills.create method #2017 slackbot.skills.create
  2. feat: add slackbot.skills.info method #2018 slackbot.skills.info
  3. feat: add slackbot.skills.update method #2019 slackbot.skills.update 👈 this pull request
  4. feat: add slackbot.skills.list method #2020 slackbot.skills.list
  5. feat: add slackbot.skills.library.add method #2021 slackbot.skills.library.add
  6. feat: add slackbot.skills.library.remove method #2022 slackbot.skills.library.remove
  7. feat: add admin.slackbot.skills.list method #2023 admin.slackbot.skills.list
  8. feat: add admin.slackbot.skills.publish method #2024 admin.slackbot.skills.publish
  9. feat: add admin.slackbot.skills.setAutoEnabled method #2025 admin.slackbot.skills.setAutoEnabled
  10. feat: add admin.slackbot.skills.unpublish method #2026 admin.slackbot.skills.unpublish
  11. feat: add slackbot.skills.delete method #2027 slackbot.skills.delete

Testing

With a token that has the skills:write scope:

  1. Call client.slackbot_skills_update(skill_id=..., description="Updated.", mcp_servers=[]) and confirm the returned skill.mcp_servers is [].
  2. Repeat with AsyncWebClient to check the generated async method.

Each layer of this stack was checked against an Enterprise developer sandbox by running every method added so far, in order, with that layer's WebClient.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

🤖 Generated with Claude Code

zimeg and others added 3 commits November 11, 2026 19:56
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.38%. Comparing base (e3125de) to head (46c1795).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
slack_sdk/web/async_client.py 83.33% 1 Missing ⚠️
slack_sdk/web/client.py 83.33% 1 Missing ⚠️
slack_sdk/web/legacy_client.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
+ Coverage   84.36%   84.38%   +0.02%     
==========================================
  Files         118      118              
  Lines       13857    13875      +18     
==========================================
+ Hits        11690    11709      +19     
+ Misses       2167     2166       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

zimeg and others added 10 commits November 11, 2026 20:18
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…kills-create

# Conflicts:
#	tests/slack_sdk_async/web/test_web_client_coverage.py
…kbot-skills-info

# Conflicts:
#	tests/slack_sdk_async/web/test_web_client_coverage.py
…ot-skills-update

# Conflicts:
#	tests/slack_sdk_async/web/test_web_client_coverage.py
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg and others added 4 commits November 11, 2026 21:24
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…kbot-skills-info

# Conflicts:
#	slack_sdk/web/async_client.py
#	slack_sdk/web/client.py
#	slack_sdk/web/legacy_client.py
#	tests/slack_sdk_async/web/test_web_client_coverage.py
…ot-skills-update

# Conflicts:
#	slack_sdk/web/async_client.py
#	slack_sdk/web/client.py
#	slack_sdk/web/legacy_client.py
#	tests/slack_sdk_async/web/test_web_client_coverage.py
@zimeg
zimeg marked this pull request as ready for review November 12, 2026 23:43
@zimeg
zimeg requested a review from a team as a code owner November 12, 2026 23:43
zimeg and others added 3 commits November 12, 2026 16:00
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
…kbot-skills-info

# Conflicts:
#	tests/slack_sdk_async/web/test_web_client_coverage.py
…ot-skills-update

# Conflicts:
#	tests/slack_sdk_async/web/test_web_client_coverage.py
Base automatically changed from zimeg-feat-slackbot-skills-info to main November 13, 2026 00:36
…kills-update

# Conflicts:
#	slack_sdk/web/async_client.py
#	slack_sdk/web/client.py
#	slack_sdk/web/legacy_client.py
#	tests/slack_sdk_async/web/test_web_client_coverage.py
@zimeg
zimeg merged commit 30e0bb3 into main Nov 13, 2026
19 checks passed
@zimeg
zimeg deleted the zimeg-feat-slackbot-skills-update branch November 13, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality semver:minor web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant