Repository navigation
Conversation
cjmayo
requested review from
1st1,
AA-Turner,
dstufft,
encukou,
ericsnowcurrently,
gvanrossum,
hugovk,
markshannon,
ncoghlan and
vstinner
as code owners
November 11, 2026 19:27
gvanrossum
removed their request for review
November 11, 2026 20:09
Secrus
reviewed
Nov 12, 2026
Secrus
left a comment
Contributor
There was a problem hiding this comment.
Some initial opinions. Last word is on the PEP maintainers team though.
|
|
||
| These optional categories are known as | ||
| `Extras <Extras (optional dependencies)_>`_. In addition to the four | ||
| :ref:`Extras <pep426-extras-optional-dependencies>`. In addition to the four |
Contributor
There was a problem hiding this comment.
I think it's better to leave the previous link syntax if possible.
| Sphinx >= 8.2 | ||
| # 0.22 causes build errors, see https://github.com/python/peps/issues/4924 | ||
| docutils < 0.22 | ||
| docutils |
Contributor
There was a problem hiding this comment.
Let's add a minimal requirement, docutils >= 0.22
Comment on lines
+1902
to
+1908
| * "Partial polymorphic type inference is undecidable" by Hans Boehm: https://dl.acm.org/doi/10.1109/SFCS.1985.44 | ||
| * "On the Undecidability of Partial Polymorphic Type Reconstruction" by Frank Pfenning: https://www.cs.cmu.edu/~fp/papers/CMU-CS-92-105.pdf | ||
| Our setting does not try to infer generic types for functions, | ||
| though, which might dodge some of the problems. On the other hand, | ||
| we have subtyping. (Honestly we are already pretty deep into some | ||
| of these cans of worms.) | ||
| Our setting does not try to infer generic types for functions, | ||
| though, which might dodge some of the problems. On the other hand, | ||
| we have subtyping. (Honestly we are already pretty deep into some | ||
| of these cans of worms.) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.