Skip to content

class-string should not be settable using string literal #223

Open

Description

@mvorisek

repro: https://phpstan.org/r/1b7e94a5-9263-4f0c-83f8-a2964c1b5d5c

This is a feature request to emit a phpstan error /w strict rules to enforce the user to set the string using Xxx::class syntax.

Xxx::class is guaranteed to be always checked by static analysis, is more readable and always in canonical form - no leading backslash.

Activity

  1. kamil-zacek commented on Apr 8, 2024

    @kamil-zacek
    Contributor

    In my opinion - rule should be little bit different. It should check whether string literal is assigned to the class-string this should check whether string contains existing class name. To avoid unnecessary autoload for files with classes only for get class name.

  2. mvorisek commented on Apr 8, 2024

    @mvorisek
    Author

    👍, like any other class (name) is checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions