Skip to content

Fix GH-11603: Set LDFLAGS - #11605

Merged
Girgias merged 1 commit into
php:masterfrom
petk:patch-11603-ld-flags
Jul 7, 2023
Merged

Girgias merged 1 commit into
php:masterfrom
petk:patch-11603-ld-flags

Conversation

@petk

@petk petk commented Jul 6, 2023

Copy link
Copy Markdown
Member

This fixes #11603

The two unsets before the last unset LIBS LDFLAGS are not necessary so LDFLAGS can be adjusted via command line:

LDFLAGS="..." ./configure

More info was discussed here #10678

The two unsets before the last `unset LIBS LDFLAGS` are not necessary so
LDFLAGS can be adjusted via command line:

LDFLAGS="..." ./configure

Co-authored-by: Max Kellermann <max.kellermann@ionos.com>

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgment @petk

@Girgias
Girgias merged commit cf587c1 into php:master Jul 7, 2023
@iluuu1994

Copy link
Copy Markdown
Member

Maybe we should document this change in UPGRADING.internals? Just to give a hint to somebody who might be experiencing issues?

@ndossche

ndossche commented Jul 7, 2023

Copy link
Copy Markdown
Member

Maybe we should document this change in UPGRADING.internals? Just to give a hint to somebody who might be experiencing issues?

I think so, especially because of the emails on internals.

@Girgias

Girgias commented Jul 7, 2023

Copy link
Copy Markdown
Member

Done in c6e934b

@petk
petk deleted the patch-11603-ld-flags branch July 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LDFLAGS isn't honored, leading to build failures in mbstring

4 participants