Repository navigation
🌱 Remove owner-name-dependent COS cache retention - #3181
Open
perdasilva wants to merge 1 commit into
Open
perdasilva wants to merge 1 commit into
perdasilva wants to merge 1 commit into
Conversation
👷 Deploy request for olmv1 pending review.Visit the deploys page to approve it
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Apply the reduced ClusterObjectSet cache representation uniformly, regardless of owner labels, while preserving revision discovery, completion evidence, and existing metadata handling. Patch only completedAt during Helm migration with optimistic resourceVersion locking so writes from trimmed cache reads preserve detailed status and reject concurrent updates. Add coverage for label independence, status preservation, conflicts, and subsequent reconciliation. Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
refactor/remove-cod-cos-owner-labels
branch
from
November 17, 2026 07:56
7a8abf4 to
2fc0078
Compare
Contributor
Author
|
/hold while we decide whether we really want to do this |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
owner-name-dependent retention from operator-controller's ClusterObjectSet cache transform. Every COS now uses the same reduced representation, retaining the fields needed for revision discovery, status reporting, and Helm storage migration:spec.group,spec.revision, andspec.lifecycleStatestatus.completedAtandstatus.conditionsAll COSs remain visible to group-based reads. Label stamping, COD caching, and the independent object-controller cache are unchanged.
Because migration reads COSs through this reduced cache, change its completion-status write from a full status update to a merge patch of only
completedAt. Optimistic resourceVersion locking preserves concurrent changes and leaves stale reads to be reevaluated on a later reconciliation, without clearing uncached phase status or object counts.Add regression tests for label-independent trimming, retained metadata and annotation stripping, migration status preservation, conflicts, and successful subsequent reconciliation. The migration regression reproduced detailed-status loss with the old update; removing optimistic locking also caused the concurrency test to fail.
Validation
make test-unitgo test -race -tags=containers_image_openpgp ./cmd/operator-controller ./internal/operator-controller/applier -count=1golangci-lint run --build-tags containers_image_openpgp ./cmd/operator-controller/... ./internal/operator-controller/applier/...(0 issues)git diff --checkLive E2E was not run. No API definitions or generated files changed.
Reviewer Checklist
Summary by CodeRabbit