Skip to content

doc: explicitly state that corepack will be removed in v25+ - #57747

Merged
nodejs-github-bot merged 2 commits into
mainfrom
corepack-removal-version
Apr 7, 2025
Merged

doc: explicitly state that corepack will be removed in v25+#57747
nodejs-github-bot merged 2 commits into
mainfrom
corepack-removal-version

Conversation

@trivikr

@trivikr trivikr commented Apr 4, 2025

Copy link
Copy Markdown
Member

The generic "future versions of" Node.js is causing a confusion among corepack users.
Example nodejs/corepack#688 (comment)

This PR explicitly changes it to v25+ as agreed in TSC vote in nodejs/TSC#1697 (comment)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 4, 2025
@trivikr trivikr mentioned this pull request Apr 4, 2025
Closed
@trivikr trivikr changed the title docs: explicitly state that corepack will be removed in v25+ doc: explicitly state that corepack will be removed in v25+ Apr 4, 2025
@MikeMcC399

MikeMcC399 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

@trivikr

Thank you for picking this up! As you know, I unsuccessfully raised it in #57708 (comment). Admittedly there were multiple issues I raised in that one issue.

It looks like you'll need to update your commit though, to change docs: to doc:

image

@trivikr
trivikr force-pushed the corepack-removal-version branch from 683c103 to 1a83409 Compare April 4, 2025 16:32
@trivikr

trivikr commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

It looks like you'll need to update your commit though, to change docs: to doc:

Thanks! I force-pushed in 1a83409

MikeMcC399
MikeMcC399 reviewed Apr 4, 2025
View reviewed changes
Comment thread doc/api/corepack.md Resolved
@trivikr
trivikr requested review from MikeMcC399 and aduh95 and removed request for MikeMcC399 April 4, 2025 16:46
styfle
styfle approved these changes Apr 4, 2025
View reviewed changes

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarity!

MikeMcC399
MikeMcC399 reviewed Apr 5, 2025
View reviewed changes
Comment thread doc/api/corepack.md
Despite Corepack being distributed with default installs of Node.js, the package
managers managed by Corepack are not part of the Node.js distribution, and
Corepack itself will no longer be distributed with future versions of Node.js.
Corepack itself will no longer be distributed with Node.js 25+.

@MikeMcC399 MikeMcC399 Apr 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trivikr

I'll just remove the v as of now, and will wait for input from other collaborators

Using the notation from https://github.com/nodejs/release including the use of the term "release line" to refer to all releases with same major version number:

Suggested change
Corepack itself will no longer be distributed with Node.js 25+.
Corepack itself will no longer be distributed with release lines Node.js 25 and above.

You could also write "releases Node.js >=25.0.0" using semver notation.

@MikeMcC399 MikeMcC399 mentioned this pull request Apr 6, 2025
Closed
@trivikr trivikr self-assigned this Apr 7, 2025
@trivikr trivikr added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 7, 2025
@nodejs-github-bot
nodejs-github-bot merged commit b6a10f7 into main Apr 7, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Landed in b6a10f7

@nodejs-github-bot
nodejs-github-bot deleted the corepack-removal-version branch April 7, 2025 15:53
@trivikr trivikr mentioned this pull request Apr 10, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@trivikr @RafaelGSS
doc: explicitly state that corepack will be removed in v25+
e5223d9 
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises GascΓ³n <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@trivikr @RafaelGSS
doc: explicitly state that corepack will be removed in v25+
952a212 
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises GascΓ³n <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
5b79f16 
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises GascΓ³n <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@trivikr @RafaelGSS
doc: explicitly state that corepack will be removed in v25+
bfaacea 
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises GascΓ³n <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
46d463b 
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises GascΓ³n <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
561a65f 
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises GascΓ³n <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@trivikr @aduh95
doc: explicitly state that corepack will be removed in v25+
92428c2 
PR-URL: #57747
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises GascΓ³n <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
@HeinTouchableFR HeinTouchableFR mentioned this pull request Aug 22, 2026
Closed
@AndrewDongminYoo AndrewDongminYoo mentioned this pull request Oct 26, 2026
Merged
AndrewDongminYoo added a commit to AndrewDongminYoo/auto-chatter that referenced this pull request Oct 26, 2026
@AndrewDongminYoo
ci: run the test job on Node.js 26 (#259)
52263dd 
## μš”μ•½

#257μ—μ„œ μ»¨ν…Œμ΄λ„ˆλ₯Ό `node:26-bookworm-slim`으둜 μ˜¬λ Έμ§€λ§Œ CI의 test μž‘μ—…μ€ μ—¬μ „νžˆ Node.js 24둜 μ‹€ν–‰λ˜κ³  μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
이 PR은 `actions/setup-node`의 `node-version`을 `"26"`으둜 올렀 ν…ŒμŠ€νŠΈμ™€ μ»¨ν…Œμ΄λ„ˆμ˜ Node μ£Ό 버전을 맞μΆ₯λ‹ˆλ‹€.
Node.js 25λΆ€ν„° Corepack이 ν•¨κ»˜ λ°°ν¬λ˜μ§€ μ•ŠμœΌλ―€λ‘œ, `Dockerfile`κ³Ό 같은 `corepack@0.36.0`을 λ¨Όμ € μ„€μΉ˜ν•œ λ’€ `corepack enable`을 μ‹€ν–‰ν•©λ‹ˆλ‹€.

- κ·Όκ±°: [Node.js Corepack λ¬Έμ„œ](https://nodejs.org/dist/latest/docs/api/corepack.html), [nodejs/node#57747](nodejs/node#57747)
- `package.json`의 `engines`(`>=24`)와 README의 μš”κ΅¬ 버전은 바꾸지 μ•Šμ•˜μŠ΅λ‹ˆλ‹€. Node 24도 계속 지원 λ²”μœ„μž…λ‹ˆλ‹€.

## 검증

- `trunk check .github/workflows/ci.yaml` β†’ exit 0
- 이 PR의 CI test μž‘μ—…μ΄ Node.js 26μ—μ„œ type check, unit, DB, workerd 검사λ₯Ό μ‹€ν–‰ν•˜λŠ” 것이 μ‹€μ œ κ²€μ¦μž…λ‹ˆλ‹€.

## Decisions taken where the brief was silent

- corepack 버전은 `Dockerfile`κ³Ό 같은 0.36.0으둜 κ³ μ •ν–ˆμŠ΅λ‹ˆλ‹€. 두 곳의 버전을 ν•¨κ»˜ μ˜¬λ €μ•Ό ν•©λ‹ˆλ‹€.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcC399 MikeMcC399 MikeMcC399 left review comments
@ljharb ljharb ljharb approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@gurgunday gurgunday gurgunday approved these changes
@aduh95 aduh95 Awaiting requested review from aduh95
+2 more reviewers
@styfle styfle styfle approved these changes
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trivikr trivikr

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.