Skip to content

Bump @vscode/diff to 0.0.2-145 - #348519

Merged
Henning Dieterichs (hediet) merged 1 commit into
mainfrom
hediet/diff-bump-145
Nov 16, 2026
Merged

Henning Dieterichs (hediet) merged 1 commit into
mainfrom
hediet/diff-bump-145

Conversation

@hediet

Copy link
Copy Markdown
Member

Bumps @vscode/diff from 0.0.2-128 to 0.0.2-145 in the root, remote and remote/web manifests and lockfiles. Only the @vscode/diff lockfile entries change.

What changes for advanced-wasm / advanced-external:

  • microsoft/vscode-packages#446: the wasm backend produces exactly the TS backend's diffs.
  • microsoft/vscode-packages#447: the wasm backend computes moved lines itself (same results as TS).
  • microsoft/vscode-packages#445: wasm loads in Electron windows with node integration (only VS Code's unit tests run there).

The default advanced algorithm is unchanged.

Validation:

  • pnpm install --lockfile-only --frozen-lockfile in the root and in remote: passed.
  • scripts\test.bat --run src/vs/editor/test/node/diffing/fixtures.test.ts --run src/vs/editor/test/common/services/editorWebWorker.test.ts: 150 passing (includes the check that the package's TS engine matches the built-in algorithm on all fixtures).
  • pnpm run typecheck-client: passed.

The wasm backend now produces exactly the TS backend's diffs and computes moved lines itself (microsoft/vscode-packages#446, microsoft/vscode-packages#447), and loads in Electron windows with node integration (microsoft/vscode-packages#445).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 11:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The cited tests do not exercise WASM move computation, leaving incorrect move offsets or inner edits undetected before reaching the adapter.

1 open issue
2 files not reviewed
  • pnpm-lock.yaml: Generated file
  • remote/pnpm-lock.yaml: Generated file
What changed in this PR

Updates @vscode/diff from 0.0.2-128 to 0.0.2-145 across VS Code’s root, remote, and web dependencies. The release improves the external diff backends without changing the default advanced algorithm.

Changes:

  • Incorporates WASM diff parity, native moved-line computation, and Electron loading fixes.
  • Synchronizes all three manifests and both lockfiles; lockfile changes are limited to @vscode/diff.
File Description
remote/​web/​package.json Updates the remote web dependency.
remote/​pnpm-lock.yaml Locks the updated remote and web dependency.
remote/​package.json Updates the remote dependency.
pnpm-lock.yaml Records the updated root version and integrity hash.
package.json Updates the root dependency.

Review effort: Balanced

Comment thread package.json Resolved
@hediet
Henning Dieterichs (hediet) added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 6e6bf2f Nov 16, 2026
39 of 40 checks passed
@hediet
Henning Dieterichs (hediet) deleted the hediet/diff-bump-145 branch November 16, 2026 11:55
@vs-code-engineering vs-code-engineering Bot added this to the 1.148.0 milestone Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants