Repository navigation
editor: honor fixed width limits for Connected tabs - #348301
Merged
Cherry Wang (chryw) merged 2 commits intoNov 16, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep ordinary trailing-action fixed tabs on the shared width rules and override only the legacy leading-action floor. Add focused min/max fixtures and pinned-width regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Connected-tab fixed-width sizing changes.
No open issues 🎉
What changed in this PR
Makes Connected editor tabs honor the existing fixed-width settings instead of enforcing an 80px minimum, while preserving dedicated compact/shrink pinned-tab widths.
Changes:
- Uses shared fixed-width rules, retaining a targeted override for left-side actions.
- Adds sizing regressions covering width limits, action bounds, pinned tabs, and unchanged
fit/shrinkbehavior. - Adds two component fixtures for narrow maximum and minimum widths.
| File | Description |
|---|---|
src/vs/workbench/test/browser/parts/editor/multiEditorTabsControl.test.ts |
Adds rendered sizing and compatibility regressions. |
src/vs/workbench/test/browser/componentFixtures/editor/tabs.fixture.ts |
Adds Connected-tab fixtures for both fixed-width limits. |
src/vs/workbench/contrib/modernUI/browser/media/connectedEditorTabs.css |
Replaces the broad 80px minimum with a targeted fixed-sizing override. |
Review effort: Balanced
Cherry Wang (chryw)
marked this pull request as ready for review
November 16, 2026 03:31
Ben Villalobos (benvillalobos)
approved these changes
Nov 16, 2026
Cherry Wang (chryw)
enabled auto-merge
November 16, 2026 03:44
roblourens
approved these changes
Nov 16, 2026
Cherry Wang (chryw)
deleted the
dev/cherwan/agents/local-css-fix-vscode-340848
branch
November 16, 2026 05:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected editor tabs in
fixedmode can start scrolling before they need to. Their extra 80px minimum prevents tabs from shrinking within the existing fixed-width range, and even overrides a configured maximum below 80px.Remove that extra floor and reuse the shared fixed-sizing policy. Right-side actions inherit the shared rule; a scoped override prevents the legacy left-action minimum from taking precedence. This introduces no new sizing default. Compact/shrink sticky tabs use their own sizing rules rather than regular-tab bounds. Close visibility, action-space reservation, and
fit/shrinkbehavior are preserved.A crowded row with ordinary filenames
Eight files, a 560px editor group, and the default fixed-mode bounds of 50-160px. File icons and action-space reservation are enabled, Close is on the right, and the editor-group toolbar is hidden.
Before, tabs stop shrinking at 80px and the last file is offscreen. After, they shrink to about 69px and all eight fit without horizontal scrolling. Labels truncate more as tabs narrow; that is the intended fixed-sizing tradeoff, not a filename-readability or Close-visibility fix.
Headless production-component fixtures on Windows, using the pre-fix stylesheet for Before and the PR stylesheet for After. Content, theme, group width, selection, and scroll position are matched.
Wider groups stay unchanged
With the same files in a 960px group, the tabs look unchanged. The fix is about respecting width constraints when they matter, not making every tab smaller.
A separate check with a configured 70px maximum also renders 70px tabs instead of 80px, including with ordinary filenames and file icons.
Try it
workbench.editor.tabSizingtofixed, with its minimum and maximum at50and160.workbench.editor.tabSizingFixedMaxWidthto70. Tabs should stop at 70px, not 80px.fitandshrinkshould retain their existing behavior; compact/shrink sticky tabs should retain their dedicated widths.Checked default dark/light and high contrast, both action locations, and label/Close separation. Rendered regressions also cover configured bounds, sticky widths, action-space reservation, and the other sizing modes.
Related sizing test coverage: #335914.