Repository navigation
Conversation
…iles Before the first checksum, upload validated every entry of the description file and searched the import paths three times (images, videos, zip files), resolving every path found twice, all without output. With 100,000 images on an SSD that took about 12 seconds, and longer on network drives. - Loading the description file shows a progress bar. - The import paths are searched once for all file types, with a counter of the files looked at. - Paths are resolved with each folder resolved once (utils.PathResolver). The result is the same as Path.resolve(): a file that is a link is still resolved in full, and on Windows every path is, as resolving there also gives file names the case they have on the drive. Errors checking a file for a link are ignored, as Path.resolve() ignores them, such as for a file in a folder that can be listed but not searched. check_upload_history loads and finds files the same way, so it shows the same progress on stderr. Its JSON on stdout is unchanged. On a Mac SSD with 100,000 images, finding the files went from 7.2 s to 2.3 s. Validating the entries still takes about 5 s, now with the progress shown.
caglarpir
force-pushed
the
pre-upload-progress
branch
from
November 16, 2026 15:08
f903c78 to
58a441a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the first checksum,
uploadvalidated every entry of the description file and searched the import paths three times (images, videos, zip files), resolving every path found twice, all without output. With 100,000 images on an SSD that took about 12 seconds, and longer on network drives, so it could look stuck.utils.PathResolver). The result is the same asPath.resolve(): a file that is a link is still resolved in full, and on Windows every path is, as resolving there also gives file names the case they have on the drive. Errors checking a file for a link are ignored, asPath.resolve()ignores them (os.path.islink(), notPath.is_symlink(), which raises them before Python 3.14), such as for a file in a folder that can be listed but not searched.check_upload_historyloads and finds files the same way, so it shows the same progress on stderr. Its JSON on stdout is unchanged.Measured on a Mac SSD with 100,000 images: finding the files went from 7.2 s to 2.3 s. Validating the entries still takes about 5 s, now with the progress shown.
Tests: the new candidate tests pass on main too (same results, including links, overlapping import paths and relative paths), and tests check
PathResolveragainstPath.resolve(), including a folder that can be listed but not searched (run on Python 3.9, 3.13 and 3.14).