Static route conflict with dynamic on same level #623

Activity

1. ipfans commented on Aug 16, 2016

   

   ipfans

   on Aug 16, 2016

   Contributor

   More actions

   I think it should be some behaviour due to your code. As example:

       e := echo.New()
       g := e.Group("/g")
       g.GET("/dictionary/skills", func(ctx echo.Context) error {
           return ctx.String(200, "skills")
       })
       g.GET("/dictionary/:name", func(ctx echo.Context) error {
           return ctx.String(200, ctx.Param("name"))
       })

   Routers are working fine.
2. sokolovstas commented on Aug 16, 2016

   

   sokolovstas

   on Aug 16, 2016

   Author

   More actions

   Yes your example work as expected! Thank you for it. I will try figure out source of problem and write later.
3. sokolovstas

   closed this as completedon Aug 16, 2016
4. sokolovstas

   reopened this on Sep 23, 2016
5. sokolovstas commented on Sep 23, 2016

   

   sokolovstas

   on Sep 23, 2016

   Last edited by sokolovstas

   Author

   More actions

   Please check this exmaple. For me http://localhost:8001/g/dictionary/status return Not Found but http://localhost:8001/g/dictionary/type return type. If remove g.GET("/server", than status request work as expected.

   e := echo.New()
   g := e.Group("/g")
   g.GET("/dictionary/skills", func(ctx echo.Context) error {
       return ctx.String(200, "skills")
   })
   g.GET("/dictionary/:name", func(ctx echo.Context) error {
       return ctx.String(200, ctx.Param("name"))
   })
   g.GET("/server", func(ctx echo.Context) error {
       return ctx.String(200, "server")
   })
   

   👍React with 👍3Reacted by Bahtiyar Biksayev, Roman Potekhin and Vitaliy Levchenko
6. sokolovstas commented on Oct 14, 2016

   

   sokolovstas

   on Oct 14, 2016

   Author

   More actions

   Hi @vishr, do you have any thought about this error?
7. vishr commented on Oct 14, 2016

   

   vishr

   on Oct 14, 2016

   Member

   More actions

   @sokolovstas I believe this issue is related to #675. I will work on it asap.
8. vishr

   self-assigned this

   on Oct 14, 2016
9. vishr

   added

   bug

   on Oct 14, 2016
10. vishr

    closed this as completedin acefe3eon Oct 14, 2016
11. vishr commented on Oct 14, 2016

    

    vishr

    on Oct 14, 2016

    Member

    More actions

    @sokolovstas please verify
12. vishr

    added 2 commits that reference this issue on Oct 14, 2016

    fixed #623

    ...

    This issue will close once commit 1dcb7ba is merged into the 'master' branch.

    1dcb7ba

    fixed #623

    ...

    This issue will close once commit 2bdbf69 is merged into the 'master' branch.

    2bdbf69
13. sokolovstas commented on Oct 19, 2016

    

    sokolovstas

    on Oct 19, 2016

    Author

    More actions

    Yes it working fine now! Many thanks for your efforts!
14. vishr

    added a commit that references this issue on Nov 3, 2016

    backport fix for #623 from v3 (#709)

    1659348