Repository navigation
Fix SSH Timeout PTY allocation - #676
Conversation
…onnections - it changes the semantics of commands such as ls Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
|
We've had a lot of TTY changes made recently for knife bootstrap, one of which broke many bootstrap scenarios. Before we merge this we need additional testing to make sure it doesn't impact the boostrap scenarios. |
|
After discussion with @tas50, I explained that this change only affects situations using the timeout feature of the SSH transports, which is relatively new and has been broken since being introduced. The change is to revert back to previous behavior, only allocating a PTY when explicitly requested. He felt comfortable with the merge if I am confident in low impact of the change, which I am. |
|
FYI @clintoncwolfe the reason for the PTY being allocated when using a timeout was to ensure that the command being executed would terminate on the target host. e.g. if you run Seems like forcing a PTY isn't the right way to do that... |
Description
Do not automatically allocate a PTY when a timeout is given for SSH connections - it changes the semantics of commands such as
ls.Related Issue
inspec/inspec#5459
Types of changes
Checklist: