Repository navigation
Support Docker for Windows - #674
Merged
Merged
Conversation
… Linux containers if docker socket is exposed via TCP Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
…ction Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supports Docker for Windows, by:
run_command_via_connectionmethod to usecmd.exewhen on Windows, rather than always using/bin/shCaveats:
/bin/shand falling back to cmd.exe if a Windows-style error message is detected.powershell.exe, you must pass the name of the executable (likelypwsh) using--shell-commandTested using the
mcr.microsoft.com/powershell:lts-nanoserver-1809image and themcr.microsoft.com/windows/servercore:ltsc2019image.Related Issue
Fixes #672
Types of changes
Checklist: