Skip to content

skip apt-cdrom repos in apt resource when parsing lists - #5138

Merged
Schwad merged 1 commit into
inspec:masterfrom
jrbeilke:bug-apt-cdrom
Jul 14, 2020
Merged

Schwad merged 1 commit into
inspec:masterfrom
jrbeilke:bug-apt-cdrom

Conversation

@jrbeilke

@jrbeilke jrbeilke commented Jul 8, 2020 •

Copy link
Copy Markdown

Signed-off-by: Jon Beilke Jonathan.Beilke@windlogics.com

Resolves #5137

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Aha! Link: https://chef.aha.io/features/SH-2545

Signed-off-by: Jon Beilke <Jonathan.Beilke@windlogics.com>
@jrbeilke
jrbeilke requested a review from a team as a code owner July 8, 2020 19:25
@jrbeilke
jrbeilke requested review from Schwad and james-stocks July 8, 2020 19:25
@chef-expeditor

chef-expeditor Bot commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

Hello jrbeilke! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@james-stocks james-stocks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @jrbeilke !

@james-stocks

Copy link
Copy Markdown
Contributor

Just waiting for the artifact-habitat check to pass before merging...

@Schwad
Schwad merged commit 934aa8d into inspec:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apt resource fails when sources include apt-cdrom repos

3 participants