Skip to content

fix(docker): honor custom USERNAME in visor entrypoint - #188

Open
omerbek wants to merge 1 commit into
hyperliquid-dex:mainfrom
omerbek:fix/custom-username-entrypoint
Open

omerbek wants to merge 1 commit into
hyperliquid-dex:mainfrom
omerbek:fix/custom-username-entrypoint

Conversation

@omerbek

@omerbek omerbek commented Nov 8, 2026

Copy link
Copy Markdown

Summary

  • Resolve hl-visor relative to the existing user-specific WORKDIR, instead of hard-coding /home/hluser in the exec-form entrypoint.
  • Add an offline default/custom-user path-resolution regression and document standalone custom-user builds.

Problem / root cause

USERNAME already controls user creation, the working directory, binary download and chmod. With --build-arg USERNAME=myuser, the downloaded executable is /home/myuser/hl-visor, while the previous entrypoint still tried /home/hluser/hl-visor.

Testing

On upstream 405cc08b17a727ee51b0f9128918955a84439915, the added bash tests/docker-entrypoint.sh passed for hluser and failed for entrypoint_test_user with No such file or directory. After the fix both cases pass.

  • bash -n tests/docker-entrypoint.sh: passed.
  • bash tests/docker-entrypoint.sh: passed (2 user cases).
  • Independent offline smoke parsed the actual JSON ENTRYPOINT and WORKDIR, launched a placeholder executable from both working directories, and verified all three original arguments were passed unchanged: passed.

These are executable-path workflow tests using a placeholder, not Docker image/container tests. Docker is not installed in the available Windows environment, and WSL cannot start (HCS_E_SERVICE_NOT_AVAILABLE), so an actual Ubuntu image build/run was not performed. No Hyperliquid binary or live network/node was executed.

Risk / compatibility

Default user, binary verification/download, node arguments and exec-form signal handling are unchanged. The entrypoint now relies on the image's configured working directory; callers overriding it must supply the appropriate entrypoint. Compose volume paths remain unchanged and still assume hluser (documented). This does not include or supersede the architecture change in #164.

Disclosure

AI-assisted implementation and test preparation; the executed checks and environment limits are listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant