Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hl-visorrelative to the existing user-specificWORKDIR, instead of hard-coding/home/hluserin the exec-form entrypoint.Problem / root cause
USERNAMEalready controls user creation, the working directory, binary download and chmod. With--build-arg USERNAME=myuser, the downloaded executable is/home/myuser/hl-visor, while the previous entrypoint still tried/home/hluser/hl-visor.Testing
On upstream
405cc08b17a727ee51b0f9128918955a84439915, the addedbash tests/docker-entrypoint.shpassed forhluserand failed forentrypoint_test_userwithNo such file or directory. After the fix both cases pass.bash -n tests/docker-entrypoint.sh: passed.bash tests/docker-entrypoint.sh: passed (2 user cases).These are executable-path workflow tests using a placeholder, not Docker image/container tests. Docker is not installed in the available Windows environment, and WSL cannot start (
HCS_E_SERVICE_NOT_AVAILABLE), so an actual Ubuntu image build/run was not performed. No Hyperliquid binary or live network/node was executed.Risk / compatibility
Default user, binary verification/download, node arguments and exec-form signal handling are unchanged. The entrypoint now relies on the image's configured working directory; callers overriding it must supply the appropriate entrypoint. Compose volume paths remain unchanged and still assume
hluser(documented). This does not include or supersede the architecture change in #164.Disclosure
AI-assisted implementation and test preparation; the executed checks and environment limits are listed above.