Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Actor fixture coverage does not exercise the new modifier, generic, constraint, or inheritance captures, nor verify that an explicit initializer prevents generation of an additional initializer.
1 open issue
What changed in this PR
This PR adds Swift actor support to the unified extractor, representing actors as class-like declarations while retaining the actor modifier.
Changes:
- Preserve declaration modifiers, generic parameters and constraints, inherited types, and members.
- Reuse class-style implicit initializer handling.
- Regenerate the existing actor fixture’s expected output.
| File | Description |
|---|---|
unified/extractor/tests/corpus/swift/types/actor-declaration.output |
Replaces unsupported-node output with an actor declaration and generated initializer. |
unified/extractor/src/languages/swift/swift.rs |
Adds actor translation and removes the unsupported-node fallback. |
Review effort: Balanced (auto)
Comment on lines
+1352
to
+1356
| genericParameterClause: (genericParameterClause | ||
| parameters: _* @params | ||
| genericWhereClause: (genericWhereClause requirements: _* @parameter_constraints)?)? | ||
| inheritanceClause: (inheritanceClause inheritedTypes: (inheritedType type: @bases)*)? | ||
| genericWhereClause: (genericWhereClause requirements: _* @declaration_constraints)? |
paldepind
force-pushed
the
unified/actor-decl
branch
from
November 9, 2026 15:00
17b4254 to
5245ca3
Compare
paldepind
force-pushed
the
unified/actor-decl
branch
from
November 9, 2026 15:03
5245ca3 to
018400a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map Swift
actorDeclnodes to class-like declarations, preserving modifiers, generic parameters and constraints, inherited types, and members. Reuse class-style implicit initializer handling.