Repository navigation
fix(install): a local refresh refuses the home directory (#3234) - #3288
Open
LuisAlbertoMK wants to merge 1 commit into
Open
LuisAlbertoMK wants to merge 1 commit into
LuisAlbertoMK wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A project-local install resolves every path from the working directory. Run from your home directory (or a filesystem root),
codegraph install --refresh— whichcodegraph upgraderuns by default — wrote the CodeGraph instructions block into$HOME/AGENTS.md, the user's own global instructions file, not a project's.<cwd>/.codexresolving to~/.codexmade Codex's local layer look already configured, so the sweep rewrote it.refreshTargetsnow refuses alocalsweep from a directory thatunsafeIndexRootReasonalready rejects forinit(home directory, a parent of it, or a filesystem root). Every target reports a newskippedstatus with the reason, and the CLI says why and points at running it from a project directory. Global refresh is unchanged.Added two tests in
installer-targets.test.ts: one that seeds a global Codex install and refreshes from$HOME, asserting every report isskippedand no$HOME/AGENTS.mdappears; and one that a real project-local refresh still works.Tested:
tsc --noEmitclean,npm run build, focused tests (new ones +cli-install-init+status-json), and the fullinstaller-targetsfile (576 passed, 50 skipped).