Repository navigation
fix(cli): init reports an incomplete index instead of 'Already initialized' (#3228) - #3282
Open
LuisAlbertoMK wants to merge 1 commit into
Open
LuisAlbertoMK wants to merge 1 commit into
LuisAlbertoMK wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3223.
When a first index stops partway (OOM, killed mid-index, etc.), the schema can be present while the index is incomplete. \codegraph init\ then printed 'Already initialized in ' with no hint that the index is incomplete, so it read like a working setup that just needed updating.
Now
unInit\ opens the project read-only and checks \getIndexState(). When the state is not 'complete' (e.g. 'indexing', 'partial', 'failed'), it warns that the last run did not finish and tells the user to run \codegraph index\ to rebuild. Otherwise it keeps the previous 'Already initialized' message.
Added a test in cli-install-init.test.ts that seeds index_state='indexing' and asserts the new message (and that 'Already initialized' is not printed).
Tested: tsc --noEmit clean, npm run build, focused cli-install-init suite (5 tests pass).