Repository navigation
docs(skills): stop mutate.sh on a check.sh tool error and refuse a second --fact - #689
Conversation
…cond --fact mutate.sh exits 3 with check.sh's error when check.sh cannot run on an unmodified config, instead of reporting a failing baseline. check.sh refuses a second --fact. SKILL.md lists PushClaimExpiresAt among the lane columns toRepoUpstream copies. _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: Iba285f22612ee8e06fa1cd717d958cdbdab043df Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…real error mutate.sh now runs every config's unmodified baseline before it edits any file, so a check.sh exit 3 stops the run before the first break. Its exit-3 message quotes check.sh's own error line or TLC's Error: line instead of the last output line. SKILL.md calls the toRepoUpstream columns the push-lane protocol columns. _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: I9eb7f9311cfc39909e88b7a50c6cc1f68355d303 Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Change-Id: Ib57fdfb972853f6f778efdd69495112629eb8181 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Why
verify-lane-schedulemust claim only what it checks, and a reader must be able to rerun its Validation steps. The final review of #677 found three small gaps, and this PR fixes them.What
mutate.shnow runs each config it uses unmodified before its first break. Whencheck.shcannot run at all there (exit 3, for example a missing Java or a TLC error),mutate.shstops with exit 3 before any break, and prints check.sh's own error line or TLC'sError:line. Before, it printed "BASELINE ... does not pass unmodified" and exited 1, which reads like a model failure, and it ran the LaneSchedule.cfg baseline only after the first break.check.shrefuses a second--factwith exit 3. Before,--fact A=FALSE --fact B=FALSEsilently flipped only B.PushClaimExpiresAtamong the S3-WAL push-lane protocol columns thattoRepoUpstreamcopies.worker_push.goreads it.Validation
JAVA=/nonexistent/java mutate.sh --model: exit 3, with "check.sh could not run on unmodified Liveness.cfg (exit 3, ...): check.sh: needs Java 11+".MaxRetriesremoved fromLaneSchedule.cfg:mutate.shexits 3 with "Error: The constant parameter MaxRetries is not assigned a value by the configuration file.", prints no break line, and leavesgit diffempty.check.sh --fingerprints-only --fact ClaimMarksDue=FALSE --fact RetryRemarks=FALSE: exit 3, "--fact takes one fact per run".mutate.sh --modelandmutate.sh: bothCOUNT: 9/9, andgit statusshowed only the uncommitted skill files afterwards.check.sh --fingerprints-only: exit 0. shellcheck (check.sh,mutate.sh) andscripts/check-doc-links.pypass.No product code changes.
Refs #677
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high