Repository navigation
docs(api): list only the status strings a commit-write failure envelope carries - #671
Conversation
…pe carries Change-Id: I479a8a953128c1e437bdc18d31a65c6323707854 Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Why
Follow-up to #668 (issue #665). The clean-context advisor on #668 found that
docs/explanation/streaming-commit-protocols.md§3 still said a failure envelope'sresult.statusis one of 11 strings. Since #663 and #669, commit-pack, diff-commit and restore-commit send the envelope only on 400, 409, 412 and 413. So the only possible strings areinvalid,conflict,failed,precondition_failedandpayload_too_large.What changes
One sentence in §3 now names those five strings with their HTTP statuses. The SDK mapping table below it does not change, because SDKs still map any status.
Docs only. No code or wire change.
Checks
python3 scripts/check-doc-links.py(0 broken) and the script unit tests pass.Refs #665
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high