Repository navigation
refactor: make kube-state-metrics and node-exporter top-level subcharts - #101
Merged
Merged
Conversation
They were dependencies of the prometheus subchart, so they could not run without the Prometheus server. Rendered manifests are unchanged with default values. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ELOG placement Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
droopy4096
reviewed
Nov 6, 2026
…exporter is re-enabled Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
droopy4096
approved these changes
Nov 6, 2026
droopy4096
left a comment
There was a problem hiding this comment.
Right, checked a4cb4df locally: re-enabling either nested copy now fails with a proper clear message, old overrides still point to the new key, and default values render same as before. Sorted.
🤖 John Claude on behalf of Dmytro Makovey
Regenerated Chart.lock digest after combining grafana 10.5.15 with the new top-level kube-state-metrics and prometheus-node-exporter deps. Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kube-state-metricsandprometheus-node-exporterwere dependencies of theprometheussubchart, so disablingprometheusalso dropped them, and there is no way to disable only the Prometheus server. That blocks running just the collector side (Alloy, kube-state-metrics, node-exporter) in a cluster whose metrics go to a Prometheus elsewhere.This makes both top-level dependencies with their own
enabledflags. Theprometheuschart's copies are disabled.kube-state-metrics8.0.0,prometheus-node-exporter4.56.1, pinned to whatprometheus29.20.1 resolved to).fullnameOverride, pod annotations and node-exporter'scontainerSecurityContext/rbacdefaults (which came from the prometheus chart) move with them.compiled/resources.yamlresource by resource, and there are no differences. Thecompiled/diff is only resource ordering.BREAKING for values overrides:
prometheus.kube-state-metrics.*andprometheus.prometheus-node-exporter.*become top-levelkube-state-metrics.*andprometheus-node-exporter.*(noted in the CHANGELOG). The dogfood repo'smetricLabelsAllowlistoverride is the only one I know of.prometheus.kube-state-metricsorprometheus.prometheus-node-exporter(other than the chart's ownenabled,rbacandcontainerSecurityContextdefaults), so it can't be ignored silently.prometheuschart; bump it by hand.prometheus.enabled: falserender. That needs feat: let the collector write to a Prometheus outside the release #102 (global.telemetry.metrics.remoteWriteURL); the two are meant to ship together.🤖 Generated with Claude Code