Repository navigation
[core] Avoid deadlocks between concurrent JDBC catalog renames - #11342
Open
zhangyue19921010 wants to merge 1 commit into
Open
zhangyue19921010 wants to merge 1 commit into
zhangyue19921010 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #11341.
Concurrent JDBC catalog renames of different objects can acquire the same two local lock stripes in opposite order and deadlock. Acquire local stripes in stripe order before entering the existing identifier order for distributed locks. Table and view renames share this helper.
Tests
Added a deterministic regression using real JDBC catalog table renames with colliding stripes. It fails on unchanged production code and passes after the fix.
Ran the regression and neighboring catalog/view, lease and executor serialization tests: 111 pass with normal Maven checks and RAT (JDK 11, Java 8 source target).