Repository navigation
[common] Copy primitive DATE and TIME arrays - #11315
Open
zhangyue19921010 wants to merge 4 commits into
Open
zhangyue19921010 wants to merge 4 commits into
zhangyue19921010 wants to merge 4 commits into
Conversation
…61121 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #11314
Copying an int-backed
GenericArrayof DATE or TIME throwsUnknown type, including arrays produced byInternalRowUtils.copyArrayand rows copied by the Flink runtime serializer.Handle DATE and TIME in the existing integer-array copy branch. The copied array remains independent of the source; the serialized representation is unchanged.
Tests
Added primitive-array, producer-to-copy and row-copy regressions for nullable/non-nullable INT, DATE and TIME elements, including empty arrays, value boundaries, mutation isolation and round trips. On unchanged production code, 12 of the 18 added cases fail for DATE/TIME; all six INT controls pass.
All 45 tests in
InternalArraySerializerTest,InternalMapSerializerTestandInternalRowUtilsTestpass with normal Maven checks enabled (JDK 11, Java 8 source target). An exact-source Flink 1.20.1 serializer probe also passes all six INT/DATE/TIME cases across both copy overloads; the four DATE/TIME cases fail on the baseline. No full Flink job was run.