Repository navigation
[common] Preserve NULL values in complex default literals - #11312
Open
zhangyue19921010 wants to merge 4 commits into
Open
zhangyue19921010 wants to merge 4 commits into
zhangyue19921010 wants to merge 4 commits into
Conversation
…61121 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #11311
Creating a table with defaults such as
ARRAY(1, NULL),MAP(1, NULL)orSTRUCT(1, NULL)fails because the complex cast rules treat uppercase NULL as a value to parse. Whole-value NULL defaults also fail for ARRAY and ROW.Recognize unquoted NULL case-insensitively and add whole-value NULL handling to ARRAY and ROW. Quoted and escaped null strings remain literal text. Projecting a NULL row default also preserves NULL.
Tests
Added Spark SQL create/write/read regressions and cast tests for lowercase, uppercase and mixed-case NULL, including quoted and escaped string controls. On unchanged production code, all four new Spark regressions fail and the four existing controls pass; the focused cast baseline has eight parser errors in ten cases.
All 77 tests in
CastExecutorTest,DefaultValueRowTest,CastedRowTestand SparkDefaultValueTestpass with normal Maven checks enabled (JDK 11, Spark 3.5.9). Coverage includes projecting a NULL row default.