Repository navigation
[python] Support native batch overwrite commits - #10097
Merged
JingsongLi merged 4 commits intoSep 22, 2026
Merged
Conversation
leaves12138
approved these changes
Sep 22, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Reviewed the batch-only overwrite API, preserved commit identity, static/dynamic/empty/null-partition overwrite semantics, Python option normalization, and the preflight-only fallback boundary. Native mutation failures remain outside the fallback path, so they do not trigger a second Python commit or automatic file cleanup.
Validated against a freshly built apache/paimon-rust#916 runtime:
- Nine focused commit/write/serialization/conflict/callback/deletion-vector suites: 294 passed, 51 skipped.
- Ray sink suite: 16 passed.
- Independent Python/native overwrite-then-append checks for bucket=-1 and bucket=2: passed, with matching visible rows and snapshot record counts.
- Full PyPaimon flake8 and license checks: passed.
No blocking findings. GitHub CI is still pending; this approval is based on code review and the local validation above.
XiaoHongbo-Hope
pushed a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #10081. Enable batch overwrite through the existing opt-in
commit.native.enabledroute, using apache/paimon-rust#916 on top of the merged apache/paimon-rust#915.overwrite()and its configuration fromWriteBuildertoBatchWriteBuilder.StreamWriteBuilderno longer exposes overwrite; stream writer/committer constructors accept only the table and commit user.BatchTableCommit, preserving the Python writer's identity via the internal batch builder bridge. Remove the proposed stream overwrite route and its tests. Noisinstancemode guard or older-Rust API compatibility probes are needed.offand0for native overwrite/ignore-empty options.Usage
The existing dynamic overwrite default is unchanged; set
dynamic-partition-overwrite=falsefor static partition matching as in this example. Overwrite is available only through the batch API, following Java.Verification
native_commit_test.py,table_commit_test.py,file_store_commit_test.py,commit_message_serializer_test.py,overwrite_commit_conflict_test.py,write/commit_callback_test.py,write/changelog_producer_test.py, andwrite/table_write_test.py: 214 passed, 8 subtests passed. The suite was run outside the sandbox because the ORC reader needs local sysctl hardware information.ray_sink_test.py. That Ray-specific test could not be collected locally becauserayis not installed; the builder API boundary is covered by the passing native commit suite.git diff --checkpassed.