Repository navigation
Conversation
Contributor
|
@mbeijen sorry there is a conflict now. |
A request line over LimitRequestLine was not rejected over HTTP/3. The path went on to the core, which failed to map it, logged AH00036 "File name too long" and answered 403 instead of 414. Check the request line that mod_http3 builds from the pseudo-headers against LimitRequestLine and answer 414, with the same message as HTTP/1.1. * modules/http3/h3_request.c (stream_worker): Check the_request against LimitRequestLine. * test/modules/http3/test_104_headers.py (test_h3_104_10_request_line): Expect 414 instead of marking it as a known bug. Generated-by: Claude Code (Claude Opus 5.5)
mbeijen
force-pushed
the
h3-limit-request-line
branch
from
November 10, 2026 14:00
766d87a to
b72c8ac
Compare
Contributor
Author
No worries, I rebased and fixed the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over HTTP/3, a request line longer than
LimitRequestLinewas not rejected. The path went on to the core, which failed to map it, loggedAH00036("File name too long") and answered 403 instead of 414. This checks the request line that mod_http3 builds from the pseudo-headers againstLimitRequestLineand answers 414 with the same message as HTTP/1.1, like mod_http2 does for its pseudo-headers.test_h3_104_10_request_linenow expects the 414 instead of marking it as a known bug. It currently errors on theAH00036in the log, which would make the mod_http3 CI job proposed in #945 fail.This change was prepared with AI support and reviewed by me.
SECURITY.mdand https://www.apache.org/security/#reporting-a-vulnerability).APLOGNO()tag; numbers are assigned by a committer at merge time (seedocs/log-message-tags/README).changes-entries/*.txtfile is included, following the template inREADME.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source, ortest/modules/corefor core server changes. On Unix, verify these pass locally with e.g.make check-pytest PYTEST_DIRS=test/modules/xxx.