Skip to content

mod_http3: Apply LimitRequestLine to HTTP/3 requests - #985

Open
mbeijen wants to merge 1 commit into
apache:trunkfrom
mbeijen:h3-limit-request-line
Open

mbeijen wants to merge 1 commit into
apache:trunkfrom
mbeijen:h3-limit-request-line

Conversation

@mbeijen

@mbeijen mbeijen commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Over HTTP/3, a request line longer than LimitRequestLine was not rejected. The path went on to the core, which failed to map it, logged AH00036 ("File name too long") and answered 403 instead of 414. This checks the request line that mod_http3 builds from the pseudo-headers against LimitRequestLine and answers 414 with the same message as HTTP/1.1, like mod_http2 does for its pseudo-headers.

test_h3_104_10_request_line now expects the 414 instead of marking it as a known bug. It currently errors on the AH00036 in the log, which would make the mod_http3 CI job proposed in #945 fail.

This change was prepared with AI support and reviewed by me.


  • This PR does not report or address a security vulnerability (see SECURITY.md and https://www.apache.org/security/#reporting-a-vulnerability).
  • Code follows the httpd style guide.
  • New log messages (level debug or higher) use an empty APLOGNO() tag; numbers are assigned by a committer at merge time (see docs/log-message-tags/README).
  • If the change is user-visible, a changes-entries/*.txt file is included, following the template in README.CHANGES (not needed otherwise).
  • Test cases based on pyhttpd are included where appropriate, in the test/modules/xxx directory matching the modules/xxx module source, or test/modules/core for core server changes. On Unix, verify these pass locally with e.g. make check-pytest PYTEST_DIRS=test/modules/xxx.

@jfclere

jfclere commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@mbeijen sorry there is a conflict now.

A request line over LimitRequestLine was not rejected over HTTP/3.
The path went on to the core, which failed to map it, logged AH00036
"File name too long" and answered 403 instead of 414.

Check the request line that mod_http3 builds from the pseudo-headers
against LimitRequestLine and answer 414, with the same message as
HTTP/1.1.

* modules/http3/h3_request.c (stream_worker): Check the_request
  against LimitRequestLine.

* test/modules/http3/test_104_headers.py (test_h3_104_10_request_line):
  Expect 414 instead of marking it as a known bug.

Generated-by: Claude Code (Claude Opus 5.5)
@mbeijen
mbeijen force-pushed the h3-limit-request-line branch from 766d87a to b72c8ac Compare November 10, 2026 14:00
@mbeijen

mbeijen commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

@mbeijen sorry there is a conflict now.

No worries, I rebased and fixed the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants